Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused. #1428

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Delete unused. #1428

merged 1 commit into from
Nov 10, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Nov 8, 2020

@mrook this was just a hangover, or?

@siad007 siad007 requested a review from mrook November 8, 2020 23:28
@siad007 siad007 added cleanup code cleanup core labels Nov 8, 2020
@siad007 siad007 added this to the 3.0.0-rc1 milestone Nov 8, 2020
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #1428 (f337f3d) into master (50b7930) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1428   +/-   ##
=========================================
  Coverage     54.27%   54.27%           
  Complexity     9119     9119           
=========================================
  Files           467      467           
  Lines         22153    22153           
=========================================
  Hits          12024    12024           
  Misses        10129    10129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b7930...f337f3d. Read the comment docs.

@mrook
Copy link
Member

mrook commented Nov 10, 2020

Yeah we're not using this anymore.

@mrook mrook merged commit 6590ad5 into master Nov 10, 2020
@siad007 siad007 deleted the siad007-patch-3 branch November 10, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

2 participants