Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpRequest] Fixed verbose mode. #1389

Merged
merged 1 commit into from
Sep 3, 2020
Merged

[HttpRequest] Fixed verbose mode. #1389

merged 1 commit into from
Sep 3, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 3, 2020

Added missing constructor dependency if in verbose mode.

@siad007 siad007 added the defect label Sep 3, 2020
@siad007 siad007 added this to the 3.0.0-rc1 milestone Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1389 into master will increase coverage by 0.58%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1389      +/-   ##
============================================
+ Coverage     52.48%   53.06%   +0.58%     
- Complexity     9307     9309       +2     
============================================
  Files           476      477       +1     
  Lines         22704    22699       -5     
============================================
+ Hits          11916    12046     +130     
+ Misses        10788    10653     -135     
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/HttpRequestTask.php 85.71% <0.00%> (ø) 19.00 <0.00> (ø)
classes/phing/tasks/ext/phploc/PHPLocTask.php 61.22% <50.00%> (+61.22%) 44.00 <0.00> (ø)
...ses/phing/tasks/ext/phploc/PHPLocJSONFormatter.php 80.00% <80.00%> (ø) 2.00 <2.00> (?)
...ses/phing/tasks/ext/phploc/PHPLocTextFormatter.php 88.88% <85.71%> (+88.88%) 2.00 <0.00> (ø)
.../phing/tasks/ext/phploc/PHPLocFormatterFactory.php 90.90% <100.00%> (+90.90%) 6.00 <0.00> (+1.00)
...sses/phing/tasks/ext/phploc/PHPLocXMLFormatter.php 80.00% <100.00%> (+80.00%) 2.00 <0.00> (-1.00) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6a501...e9404d2. Read the comment docs.

@siad007 siad007 merged commit 06668f8 into master Sep 3, 2020
@siad007 siad007 deleted the siad007-patch-4 branch September 3, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant