Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SubPhing] Fail on error should also be passed to the phing task. #1361

Merged
merged 1 commit into from
Jul 4, 2020
Merged

[SubPhing] Fail on error should also be passed to the phing task. #1361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions classes/phing/tasks/system/SubPhing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,17 +213,17 @@ private function execute(PhingFile $file, ?PhingFile $directory)
}

/**
* Creates the <ant> task configured to run a specific target.
* Creates the <phing> task configured to run a specific target.
*
* @param directory : if not null the directory where the build should run
* @param ?PhingFile $directory : if not null the directory where the build should run
*
* @return PhingTask the ant task, configured with the explicit properties and
* @return PhingTask the phing task, configured with the explicit properties and
* references necessary to run the sub-build.
*/
private function createPhingTask(?PhingFile $directory): PhingTask
{
$phingTask = new PhingTask($this);
$phingTask->setHaltOnFailure(true);
$phingTask->setHaltOnFailure($this->failOnError);
$phingTask->init();
if ($this->subTarget !== null && $this->subTarget !== '') {
$phingTask->setTarget($this->subTarget);
Expand Down