Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phing] Simplified os family condition #1308

Merged
merged 1 commit into from
Apr 11, 2020
Merged

[Phing] Simplified os family condition #1308

merged 1 commit into from
Apr 11, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 11, 2020

No description provided.

@siad007 siad007 added core cleanup code cleanup labels Apr 11, 2020
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Apr 11, 2020
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #1308 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1308      +/-   ##
============================================
- Coverage     51.61%   51.61%   -0.01%     
+ Complexity     9281     9279       -2     
============================================
  Files           477      477              
  Lines         22674    22667       -7     
============================================
- Hits          11704    11700       -4     
+ Misses        10970    10967       -3     
Impacted Files Coverage Δ Complexity Δ
classes/phing/Phing.php 36.29% <100.00%> (-0.22%) 232.00 <0.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844995a...68b5ac8. Read the comment docs.

@siad007 siad007 merged commit 62752af into master Apr 11, 2020
@siad007 siad007 deleted the siad007-patch-2 branch April 11, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

1 participant