Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhingTask] Fixed multi same property #1296

Merged
merged 6 commits into from
Mar 29, 2020
Merged

[PhingTask] Fixed multi same property #1296

merged 6 commits into from
Mar 29, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 29, 2020

Fixed following behavior:

    <target name="multi-same-property">
        <phing phingfile="phing.xml" target="echo-for-multi-same">
            <property name="prop" value="one"/>
            <property name="prop" value="two"/>
        </phing>
    </target>

    <target name="echo-for-multi-same">
        <echo>prop is ${prop}</echo>
    </target>

will output:

prop is one
prop is one

Related to #1241

For same properties last setted should win.
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #1296 into master will increase coverage by 0.00%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1296   +/-   ##
=========================================
  Coverage     51.21%   51.21%           
- Complexity     9302     9306    +4     
=========================================
  Files           479      479           
  Lines         22751    22753    +2     
=========================================
+ Hits          11652    11654    +2     
  Misses        11099    11099           
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/ForeachTask.php 68.98% <ø> (-0.77%) 56.00 <0.00> (ø)
classes/phing/tasks/system/PhingTask.php 74.89% <85.18%> (+0.65%) 91.00 <0.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f15e5...4fb4531. Read the comment docs.

@siad007 siad007 merged commit 3372b21 into master Mar 29, 2020
@siad007 siad007 deleted the siad007-patch-2 branch March 29, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant