Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyTask] reduce complexity by extract method #1287

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 1, 2020

No description provided.

@siad007 siad007 added system tasks refactor cleanup code cleanup scrutinizer fixed scrutinizer issue labels Mar 1, 2020
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Mar 1, 2020
@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #1287 into master will increase coverage by <.01%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1287      +/-   ##
============================================
+ Coverage      51.8%   51.81%   +<.01%     
- Complexity     9296     9297       +1     
============================================
  Files           479      479              
  Lines         22787    22789       +2     
============================================
+ Hits          11805    11807       +2     
  Misses        10982    10982
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/PropertyTask.php 80.34% <53.84%> (+0.22%) 76 <8> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e36e1...b0f166a. Read the comment docs.

@siad007 siad007 merged commit 28d1211 into master Mar 1, 2020
@siad007 siad007 deleted the siad007-patch-1 branch March 1, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup refactor scrutinizer fixed scrutinizer issue system tasks
Development

Successfully merging this pull request may close these issues.

1 participant