Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZipTask] fixed basedir #1255

Merged
merged 3 commits into from
Feb 9, 2020
Merged

[ZipTask] fixed basedir #1255

merged 3 commits into from
Feb 9, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Feb 9, 2020

Related to #1242

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Feb 9, 2020
@siad007 siad007 linked an issue Feb 9, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #1255 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1255      +/-   ##
============================================
+ Coverage      50.1%   50.18%   +0.08%     
  Complexity     9503     9503              
============================================
  Files           486      486              
  Lines         23300    23300              
============================================
+ Hits          11675    11694      +19     
+ Misses        11625    11606      -19
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/ZipTask.php 62.5% <100%> (+7.95%) 38 <0> (ø) ⬇️
classes/phing/types/AbstractFileSet.php 73.5% <0%> (+4.5%) 90% <0%> (ø) ⬇️
classes/phing/tasks/ext/ZipFileSet.php 90.47% <0%> (+14.28%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c3679...5c18ee0. Read the comment docs.

@siad007 siad007 merged commit 50cdb6d into master Feb 9, 2020
@siad007 siad007 deleted the siad007-patch-1 branch February 9, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

ZipTask cannot create zip using basedir
1 participant