Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify visualizer tests #1247

Merged
merged 10 commits into from
Jan 28, 2020

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Jan 28, 2020

In order to avoid errors in VisualizerTask tests, I removed any reference to any external PlantUML server.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1247 into master will decrease coverage by 0.15%.
The diff coverage is 59.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1247      +/-   ##
===========================================
- Coverage     49.65%   49.5%   -0.16%     
  Complexity     9631    9631              
===========================================
  Files           492     492              
  Lines         23568   23568              
===========================================
- Hits          11703   11667      -36     
- Misses        11865   11901      +36
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/XmlPropertyTask.php 0% <ø> (ø) 12 <0> (ø) ⬇️
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner8.php 0% <0%> (ø) 58 <0> (ø) ⬇️
classes/phing/types/selectors/SelectorAware.php 28.07% <0%> (ø) 28 <1> (ø) ⬇️
classes/phing/tasks/ext/svn/SvnBaseTask.php 0% <0%> (ø) 48 <2> (ø) ⬇️
classes/phing/Diagnostics.php 0% <0%> (ø) 19 <0> (ø) ⬇️
classes/phing/listener/MonologListener.php 10.2% <10.2%> (ø) 17 <17> (ø) ⬇️
classes/phing/RuntimeConfigurable.php 94.59% <100%> (ø) 20 <1> (ø) ⬇️
classes/phing/IntrospectionHelper.php 67.11% <100%> (ø) 85 <0> (ø) ⬇️
...s/phing/tasks/system/condition/IsTrueCondition.php 83.33% <100%> (ø) 3 <1> (ø) ⬇️
classes/phing/tasks/system/DynamicTask.php 100% <100%> (ø) 2 <2> (ø) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f17722...7296fc9. Read the comment docs.

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Jan 28, 2020
@siad007 siad007 merged commit df33b7e into phingofficial:master Jan 28, 2020
@siad007
Copy link
Member

siad007 commented Jan 28, 2020

@jawira thx

@jawira jawira deleted the simplify-visualizer-tests branch October 14, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants