Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for creating custom attributes in the parsing phase. #1237

Merged
merged 3 commits into from
Jan 18, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Jan 18, 2020

Similar to the CustomChildCreator we have now the ability to let tasks take control of their child-elements attributes aswell.

@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #1237 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1237      +/-   ##
============================================
+ Coverage     49.22%   49.23%   +0.01%     
- Complexity     9667     9670       +3     
============================================
  Files           489      490       +1     
  Lines         23677    23684       +7     
============================================
+ Hits          11654    11662       +8     
+ Misses        12023    12022       -1
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/DynamicTask.php 100% <100%> (ø) 2 <2> (?)
classes/phing/IntrospectionHelper.php 67.11% <100%> (+0.45%) 85 <0> (+1) ⬆️
classes/phing/util/PathTokenizer.php 52.17% <0%> (+4.34%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d2077...3fc115e. Read the comment docs.

@siad007 siad007 merged commit 9e00377 into phingofficial:master Jan 18, 2020
@siad007 siad007 deleted the DynamicAttribute branch January 18, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant