Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ignore-checks in tests #1193

Merged
merged 1 commit into from
Nov 24, 2019
Merged

replace ignore-checks in tests #1193

merged 1 commit into from
Nov 24, 2019

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Nov 20, 2019

This PR wants

  • replace checks for extensions, PHP versions or functions with PHPUnits @require notations
  • remove checks for HHVM because PHP 7 is incompatible with HHVM
  • remove SVN like @version tag
  • remove overwriting variable $backupGlobals because this dafault now
  • add some @require notations based on the errors I got on my windows system

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUILD FAILED
C:\projects\phing\test\build.xml:81:87 Test FAILURE (testExecutableFileIsNotExecutableThrowsException in class SonarTaskTest): Should throw BuildException because 'executable-file-is-not-executable' with message containing 'Cannot find SonarQube Scanner' (actual message 'Could not check version string. Executable appears not to be SonarQube Scanner: [non-executable-file].' instead)
Total time: 1 minute  15.54 seconds

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #1193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1193   +/-   ##
=========================================
  Coverage     47.42%   47.42%           
  Complexity     9937     9937           
=========================================
  Files           505      505           
  Lines         24409    24409           
=========================================
  Hits          11576    11576           
  Misses        12833    12833

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deab8c2...662c2d7. Read the comment docs.

@siad007
Copy link
Member

siad007 commented Nov 23, 2019

BUILD FAILED
C:\projects\phing\test\build.xml:81:87 Test FAILURE (testExecutableFileIsNotExecutableThrowsException in class SonarTaskTest): Should throw BuildException because 'executable-file-is-not-executable' with message containing 'Cannot find SonarQube Scanner' (actual message 'Could not check version string. Executable appears not to be SonarQube Scanner: [non-executable-file].' instead)
Total time: 1 minute  3.20 seconds
Command exited with code 1

@siad007 siad007 added the core label Nov 23, 2019
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Nov 23, 2019
@mimmi20
Copy link
Contributor Author

mimmi20 commented Nov 24, 2019

I misread the regex. I fixed it.

@siad007 siad007 merged commit 277293c into phingofficial:master Nov 24, 2019
@siad007
Copy link
Member

siad007 commented Nov 24, 2019

@mimmi20 👍

@mimmi20 mimmi20 deleted the replace-ignore-checks branch November 25, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants