Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coding style for test files #1188

Merged
merged 4 commits into from
Nov 16, 2019
Merged

fix coding style for test files #1188

merged 4 commits into from
Nov 16, 2019

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Nov 9, 2019

No description provided.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed:

[phpunit] Total tests run: 1050, Warnings: 0, Failures: 1, Errors: 1, Incomplete: 0, Skipped: 208, Time elapsed: 63.79018 s
BUILD FAILED
C:\projects\phing\test\build.xml:81:87 Test FAILURE (testExisting in class AutoloaderTaskTest): Failed asserting that false is true.

@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

Merging #1188 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1188   +/-   ##
=========================================
  Coverage     47.42%   47.42%           
  Complexity     9937     9937           
=========================================
  Files           505      505           
  Lines         24409    24409           
=========================================
  Hits          11576    11576           
  Misses        12833    12833
Impacted Files Coverage Δ Complexity Δ
...s/phing/tasks/ext/sass/SassTaskCompilerFactory.php 76.31% <ø> (ø) 15 <0> (ø) ⬇️
classes/phing/tasks/ext/hipchat/HipchatTask.php 0% <ø> (ø) 22 <0> (ø) ⬇️
classes/phing/listener/ProgressLogger.php 0% <ø> (ø) 16 <0> (ø) ⬇️
classes/phing/tasks/ext/PackageAsPathTask.php 0% <ø> (ø) 3 <0> (ø) ⬇️
classes/phing/tasks/ext/HttpTask.php 89.36% <ø> (ø) 19 <0> (ø) ⬇️
classes/phing/tasks/ext/ssh/ScpTask.php 0% <ø> (ø) 54 <0> (ø) ⬇️
classes/phing/tasks/ext/phpstan/PHPStanTask.php 98.09% <ø> (ø) 67 <0> (ø) ⬇️
classes/phing/tasks/system/PhpEvalTask.php 0% <ø> (ø) 32 <0> (ø) ⬇️
classes/phing/tasks/ext/ReplaceRegexpTask.php 0% <ø> (ø) 21 <0> (ø) ⬇️
classes/phing/tasks/ext/apigen/ApiGenTask.php 0% <ø> (ø) 55 <0> (ø) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77110a...85737f0. Read the comment docs.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siad007 siad007 merged commit 56a86ba into phingofficial:master Nov 16, 2019
@siad007
Copy link
Member

siad007 commented Nov 16, 2019

@mimmi20 thx 👍

@siad007 siad007 added cleanup code cleanup core labels Nov 16, 2019
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Nov 16, 2019
@mimmi20 mimmi20 deleted the fix-test-cs branch November 16, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

2 participants