Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ComposerTask code & documentation #1175

Merged
merged 6 commits into from
Oct 25, 2019

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Oct 23, 2019

This PR makes command attribute from ComposerTask required.

Could you double check this PR please?

Please note that indentation in xml files is two spaces now, this is required by .editorconfig.

As always I'm available for any comments or remarks.

Solves #1163

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1175 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1175      +/-   ##
============================================
+ Coverage     47.09%   47.09%   +<.01%     
- Complexity     9972     9973       +1     
============================================
  Files           505      505              
  Lines         24480    24483       +3     
============================================
+ Hits          11529    11531       +2     
- Misses        12951    12952       +1
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/ComposerTask.php 79.54% <75%> (-0.95%) 15 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7234862...77008ec. Read the comment docs.

@mrook mrook merged commit c6396dc into phingofficial:master Oct 25, 2019
@mrook mrook mentioned this pull request Oct 25, 2019
@jawira jawira deleted the update-composer-task branch October 27, 2019 09:29
@siad007 siad007 added the core label Nov 23, 2019
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants