Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coding style issues #1174

Merged
merged 2 commits into from
Oct 25, 2019
Merged

fix coding style issues #1174

merged 2 commits into from
Oct 25, 2019

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Oct 22, 2019

I added some rules to the ruleset.xml for the codesniffer and fixed all errors and warnings (expect the line length warning).

Some additional changes:

  • removing brackets from require_once
  • some changed lineendings done by PHPStorm

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #1174 into master will decrease coverage by <.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1174      +/-   ##
============================================
- Coverage     47.13%   47.13%   -0.01%     
+ Complexity     9973     9971       -2     
============================================
  Files           505      505              
  Lines         24483    24481       -2     
============================================
- Hits          11539    11538       -1     
+ Misses        12944    12943       -1
Impacted Files Coverage Δ Complexity Δ
classes/phing/listener/AnsiColorLogger.php 0% <ø> (ø) 17 <0> (ø) ⬇️
classes/phing/tasks/ext/TarTask.php 0% <ø> (ø) 39 <0> (ø) ⬇️
classes/phing/filters/ReplaceTokens.php 61.16% <ø> (ø) 35 <0> (ø) ⬇️
classes/phing/tasks/ext/sonar/SonarTask.php 66.42% <ø> (ø) 54 <0> (ø) ⬇️
classes/phing/types/selectors/TypeSelector.php 43.33% <ø> (ø) 13 <0> (ø) ⬇️
classes/phing/system/io/FileSystem.php 44.48% <ø> (ø) 101 <0> (ø) ⬇️
classes/phing/tasks/ext/pdo/PDOSQLExecTask.php 41.71% <ø> (ø) 75 <0> (ø) ⬇️
classes/phing/types/selectors/DepthSelector.php 0% <ø> (ø) 22 <0> (ø) ⬇️
classes/phing/filters/TabToSpaces.php 0% <ø> (ø) 10 <0> (ø) ⬇️
classes/phing/filters/TranslateGettext.php 0% <ø> (ø) 25 <0> (ø) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6396dc...aa23d01. Read the comment docs.

@mrook mrook added this to the 3.0.0-alpha4 milestone Oct 25, 2019
@mrook mrook merged commit 9f5552c into phingofficial:master Oct 25, 2019
@mimmi20 mimmi20 deleted the remove-warnings branch October 25, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants