Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The variable '$php_errormsg' is deprecated since PHP 7.2; Using error_get_last() instead #1144

Merged
merged 8 commits into from
Oct 5, 2019
Merged

The variable '$php_errormsg' is deprecated since PHP 7.2; Using error_get_last() instead #1144

merged 8 commits into from
Oct 5, 2019

Conversation

kenguest
Copy link
Member

@kenguest kenguest commented Oct 2, 2019

The variable '$php_errormsg' is deprecated since PHP 7.2; Using error_get_last() instead

Also using error_clear_last (Available since PHP 7) to clear any previously set error message
to ensure only relevant error message is referenced/used.

…_get_last() instead

Also using error_clear_last (Available since PHP 7) to clear any previously set error message
to ensure only relevant error message is referenced/used.
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #1144 into master will decrease coverage by 0.03%.
The diff coverage is 25.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1144      +/-   ##
============================================
- Coverage     45.63%   45.59%   -0.04%     
  Complexity     9968     9968              
============================================
  Files           505      505              
  Lines         24416    24465      +49     
============================================
+ Hits          11143    11156      +13     
- Misses        13273    13309      +36
Impacted Files Coverage Δ Complexity Δ
classes/phing/system/io/UnixFileSystem.php 71.15% <ø> (-0.28%) 51 <0> (ø)
classes/phing/system/io/FileOutputStream.php 82.35% <100%> (+2.35%) 6 <0> (ø) ⬇️
classes/phing/system/io/FileSystem.php 44.48% <20.33%> (-3.45%) 101 <0> (ø)
classes/phing/system/io/OutputStream.php 58.33% <25%> (-5%) 16 <0> (ø)
classes/phing/system/io/InputStream.php 42% <25%> (-0.56%) 19 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90c8b0...fe36861. Read the comment docs.

classes/phing/system/io/FileSystem.php Outdated Show resolved Hide resolved
@siad007 siad007 added the core label Oct 2, 2019
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Oct 2, 2019
@kenguest kenguest requested a review from siad007 October 4, 2019 19:57
Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siad007 siad007 merged commit 86899bf into phingofficial:master Oct 5, 2019
@mrook mrook changed the title The variable '$php_errormsg' is deprecated since PHP 7.2; Using error_get_last() instead The variable '$php_errormsg' is deprecated since PHP 7.2; Using error_get_last() instead Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants