Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringReader should be an InputStreamReader #1141

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Oct 2, 2019

Related to #1138

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Oct 2, 2019
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #1141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1141   +/-   ##
=========================================
  Coverage     47.02%   47.02%           
  Complexity     9968     9968           
=========================================
  Files           505      505           
  Lines         24489    24489           
=========================================
  Hits          11515    11515           
  Misses        12974    12974
Impacted Files Coverage Δ Complexity Δ
classes/phing/system/io/StringReader.php 22.72% <ø> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc0e69...2183f4e. Read the comment docs.

@siad007 siad007 merged commit 4786a0b into master Oct 2, 2019
@siad007 siad007 deleted the siad007-patch-2 branch October 2, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant