Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Build-Matrix #1136

Merged
merged 4 commits into from
Oct 5, 2019
Merged

add Build-Matrix #1136

merged 4 commits into from
Oct 5, 2019

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Sep 30, 2019

This PR wants to add a Build-Matrix to make the travis file more readable and group the tests.

As a result

  • as first step the composer.json and composer.lock are validated
  • as second step the coding style is checked
  • for each PHP version the project is installed with lowest and normal dependency versions
  • for each PHP version PHPUnit is run without XDebug to make the tests faster
  • an additional test is run on the nightly build of PHP without dependency limits
  • as last step PHPUnit is run with XDebug

This PR is related to PR #1129.

.travis.yml Outdated
os: linux
php: 7.2
env: DEPS="NORMAL"
script: bin/phpcs -s --standard=./ruleset.xml classes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add --config-set ignore_warnings_on_exit 1 to avoid the build to fail on warnings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the -n option as it was before.

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Oct 2, 2019
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #1136 into master will decrease coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1136      +/-   ##
============================================
- Coverage     47.02%   45.63%   -1.39%     
  Complexity     9968     9968              
============================================
  Files           505      505              
  Lines         24489    24416      -73     
============================================
- Hits          11515    11143     -372     
- Misses        12974    13273     +299
Impacted Files Coverage Δ Complexity Δ
classes/phing/util/PearPackageScanner.php 0% <0%> (-80.54%) 37% <0%> (ø)
classes/phing/types/PearPackageFileSet.php 0% <0%> (-79.49%) 13% <0%> (ø)
...g/tasks/ext/PhpCodeSnifferTaskFormatterElement.php 0% <0%> (-70.59%) 10% <0%> (ø)
...es/phing/tasks/system/condition/IsSetCondition.php 0% <0%> (-62.5%) 3% <0%> (ø)
classes/phing/tasks/ext/PhpCodeSnifferTask.php 0% <0%> (-40.32%) 94% <0%> (ø)
classes/phing/tasks/system/PhpEvalTask.php 0% <0%> (-32.4%) 32% <0%> (ø)
...sses/phing/tasks/system/condition/AndCondition.php 83.33% <0%> (-16.67%) 3% <0%> (ø)
classes/phing/util/PathTokenizer.php 50% <0%> (-9.1%) 12% <0%> (ø)
classes/phing/TaskAdapter.php 52.17% <0%> (-8.7%) 9% <0%> (ø)
classes/phing/system/io/FileParserFactory.php 75% <0%> (-6.82%) 4% <0%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc194ac...8fceee7. Read the comment docs.

@siad007 siad007 merged commit d90c8b0 into phingofficial:master Oct 5, 2019
@siad007
Copy link
Member

siad007 commented Oct 5, 2019

@mimmi20 thanks!

@mimmi20 mimmi20 deleted the add-matrix-2 branch October 5, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants