Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileHashTask should always generate a file. #1135

Merged
merged 6 commits into from
Oct 26, 2019
Merged

FileHashTask should always generate a file. #1135

merged 6 commits into from
Oct 26, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 29, 2019

We should always create a file.
Instead of:

<filehash file="${filename}" algorithm="sha512" propertyname="phar.hash"/>
<basename property="basefilename" file="${filename}"/>
<echo file="${filename}.sha512">${phar.hash} ${basefilename}</echo>

just

<filehash file="${filename}" algorithm="sha512" />

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Sep 29, 2019
@siad007 siad007 marked this pull request as ready for review September 29, 2019 01:29
@codecov
Copy link

codecov bot commented Sep 29, 2019

Codecov Report

Merging #1135 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1135      +/-   ##
============================================
+ Coverage     47.13%   47.13%   +<.01%     
  Complexity     9971     9971              
============================================
  Files           505      505              
  Lines         24481    24483       +2     
============================================
+ Hits          11538    11540       +2     
  Misses        12943    12943
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/FileHashTask.php 65.21% <100%> (+1.58%) 17 <11> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5552c...31ff6ef. Read the comment docs.

@mrook
Copy link
Member

mrook commented Oct 25, 2019

Agreed!

@siad007 siad007 merged commit 6c4dfda into master Oct 26, 2019
@siad007 siad007 deleted the siad007-patch-1 branch October 26, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants