Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added circular reference check. #1114

Merged
merged 2 commits into from
Aug 10, 2019
Merged

Added circular reference check. #1114

merged 2 commits into from
Aug 10, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Aug 10, 2019

Added missing circular reference check to AbstractFileSet::hasPatterns() and AbstractFileSet::hasSelectors()

@siad007 siad007 added the core label Aug 10, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone Aug 10, 2019
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #1114 into master will decrease coverage by 1.16%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1114      +/-   ##
============================================
- Coverage      46.9%   45.74%   -1.17%     
  Complexity     9979     9979              
============================================
  Files           505      505              
  Lines         24514    24518       +4     
============================================
- Hits          11498    11215     -283     
- Misses        13016    13303     +287
Impacted Files Coverage Δ Complexity Δ
classes/phing/types/AbstractFileSet.php 70% <0%> (-1.43%) 90 <0> (ø)
classes/phing/util/PearPackageScanner.php 0% <0%> (-80.54%) 37% <0%> (ø)
classes/phing/types/PearPackageFileSet.php 0% <0%> (-79.49%) 13% <0%> (ø)
...g/tasks/ext/PhpCodeSnifferTaskFormatterElement.php 0% <0%> (-70.59%) 10% <0%> (ø)
...es/phing/tasks/system/condition/IsSetCondition.php 0% <0%> (-62.5%) 3% <0%> (ø)
classes/phing/tasks/ext/PhpCodeSnifferTask.php 0% <0%> (-40.32%) 94% <0%> (ø)
classes/phing/tasks/system/PhpEvalTask.php 0% <0%> (-32.4%) 32% <0%> (ø)
classes/phing/IntrospectionHelper.php 66.66% <0%> (-6.02%) 84% <0%> (ø)
classes/phing/tasks/ext/hg/HgUpdateTask.php 73.52% <0%> (-5.89%) 10% <0%> (ø)
...ses/phing/tasks/system/condition/ConditionBase.php 83.52% <0%> (-3.53%) 30% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e9a24...7099b00. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #1114 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1114      +/-   ##
============================================
- Coverage      46.9%   46.89%   -0.01%     
  Complexity     9979     9979              
============================================
  Files           505      505              
  Lines         24514    24518       +4     
============================================
  Hits          11498    11498              
- Misses        13016    13020       +4
Impacted Files Coverage Δ Complexity Δ
classes/phing/types/AbstractFileSet.php 70% <0%> (-1.43%) 90 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e9a24...7099b00. Read the comment docs.

@siad007 siad007 merged commit 7568c7f into master Aug 10, 2019
@siad007 siad007 deleted the siad007-patch-1 branch August 10, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant