Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced code #1090

Merged
merged 2 commits into from
Jul 13, 2019
Merged

Reduced code #1090

merged 2 commits into from
Jul 13, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Jul 13, 2019

Uses LogLevelAware trait to avoid duplicated code.

Uses LogLevelAware trait to avoid duplicated code.
@siad007 siad007 added cleanup code cleanup core labels Jul 13, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone Jul 13, 2019
@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #1090 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1090      +/-   ##
============================================
+ Coverage     46.85%   46.88%   +0.03%     
+ Complexity    10069    10063       -6     
============================================
  Files           506      506              
  Lines         24610    24593      -17     
============================================
  Hits          11531    11531              
+ Misses        13079    13062      -17
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/ExecTask.php 86.48% <ø> (-1.26%) 80 <0> (-6)
...asses/phing/tasks/system/element/LogLevelAware.php 100% <100%> (+100%) 6 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9dab5...c460d83. Read the comment docs.

@siad007 siad007 merged commit fdc9e71 into master Jul 13, 2019
@siad007 siad007 deleted the siad007-patch-1 branch July 13, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

1 participant