Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used getDataTypeName instead of legacy code #1073

Merged
merged 1 commit into from
May 21, 2019
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented May 19, 2019

No description provided.

@siad007 siad007 added core cleanup code cleanup labels May 19, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone May 19, 2019
@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #1073 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1073      +/-   ##
============================================
- Coverage     46.74%   46.74%   -0.01%     
  Complexity    10069    10069              
============================================
  Files           506      506              
  Lines         24611    24610       -1     
============================================
- Hits          11505    11504       -1     
  Misses        13106    13106
Impacted Files Coverage Δ Complexity Δ
classes/phing/types/AbstractFileSet.php 71.64% <50%> (-0.15%) 89 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd898d7...b83b77d. Read the comment docs.

@siad007 siad007 merged commit 6c79160 into master May 21, 2019
@siad007 siad007 deleted the siad007-patch-2 branch May 21, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

1 participant