Replaced while...each loops with foreach.

[chasepeeler]

each() is deprecated in PHP 7.2

[codecov]

Codecov Report

Merging #1032 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #1032   +/-   ##
=========================================
  Coverage     46.14%   46.14%           
  Complexity    10031    10031           
=========================================
  Files           505      505           
  Lines         24462    24462           
=========================================
  Hits          11288    11288           
  Misses        13174    13174

Impacted Files	Coverage Δ	Complexity Δ
classes/phing/tasks/ext/FtpDeployTask.php	0% <0%> (ø)	64 <0> (ø)	⬇️
.../ext/pearpackage/PEARPackageFileManagerFileset.php	0% <0%> (ø)	35 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2d9d0...852f1c1. Read the comment docs.

[siad007]

@chasepeeler thanks!

[chasepeeler]

@siad007 No problem! I'm going through my code base preparing to upgrade from 7.0 to 7.3. Anytime I find something like this or the previous PR, I'm going to at least fork the repo and make the updates on my fork - which I can then use in composer instead of the main repo, if necessary. I figure small little things like this are no-brainers for a PR, though. The fact that you merge them in means I can continue to use the main repo too.

[siad007]

@chasepeeler every helping hand to make this project greater than it is already, is very welcome. 😃

[kenguest]

thanks @chasepeeler - that's the joy of opensource and pushing fixes upstream - everybody benefits!

:-)