-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed IterableFileSet #835
Conversation
@siad007 can you resolve the conflicts? |
18d511f
to
ab5a33d
Compare
In our tests we now have the following error: |
Now we have: |
You've missed the $ before the parameter name. Don't you use PhpStorm:)? |
Thanks for pointing that out @MaXal, it should be fixed now. As a general rule, I recommend not using phing master directly (if you can avoid it). We try to avoid breaking it, but that's not always possible. |
@mrook We're using Phing's master branch in our tests for PhpStorm to provide up-to-date support of Phing. That helps us to follow you in development and do small changes incrementally instead of making one big pass when you publish a release. |
@MaXal ah! I did not realize you were part of the PhpStorm team, welcome :-) |
Closes #531