Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate SPL into Phing (Trac #281) #531

Closed
phing-issues-importer opened this issue Oct 9, 2016 · 8 comments
Closed

Integrate SPL into Phing (Trac #281) #531

phing-issues-importer opened this issue Oct 9, 2016 · 8 comments

Comments

@phing-issues-importer
Copy link

phing-issues-importer commented Oct 9, 2016

Integrate [http://ru.php.net/manual/en/book.spl.php SPL] features (Iterator, ArrayAccess...) to Phing, as [http://phing.tigris.org/servlets/ReadMsg?list=dev&msgNo=782 discussed].

Migrated from https://www.phing.info/trac/ticket/281

{
    "status": "new", 
    "changetime": "2016-10-07T08:28:55", 
    "description": "Integrate [http://ru.php.net/manual/en/book.spl.php SPL] features (Iterator, ArrayAccess...) to Phing, as [http://phing.tigris.org/servlets/ReadMsg?list=dev&msgNo=782 discussed].", 
    "reporter": "alexeyshockov", 
    "cc": "mp@webfactory.de", 
    "resolution": "", 
    "_ts": "1475828935569836", 
    "component": "phing-core", 
    "summary": "Integrate SPL into Phing", 
    "priority": "major", 
    "keywords": "spl", 
    "version": "", 
    "time": "2008-09-30T12:16:02", 
    "milestone": "4.0", 
    "owner": "alexeyshockov", 
    "type": "enhancement"
}
@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20110325T09:23:04: mrook changed milestone from "TBD" to "2.5.0"

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20110627T18:57:09: mp commented:

A good place to start could be the way FileSets are handled... there is a recurring pattern all over the place that looks like

          // $fs is a FileSet
      $fromDir = $fs->getDir($this->project);
          $ds = $fs->getDirectoryScanner($this->project);
      foreach ($ds->getIncludedFiles() as $srcFile) {
              $pf = new PhingFile($fromDir, $srcFile)
              ...

that could just read

      foreach ($pf in $fs) {
              ...

I don't know whether there is a need at all to access the excludedFile from the directory scanner? When it comes to processing files and directories separately (which I've seen in a few places), PhingFile also supports isFile()/isDirectory().

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20110627T18:57:30: mp changed cc from "" to "mp@webfactory.de"

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20150909T10:05:38: Michiel Rook commented:

Refs #531 - merge IterableFileSet / FileSet
Changeset: 3f340ce

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20150909T10:05:41: Michiel Rook commented:

Refs #531 - merge IterableFileSet / FileSet
Changeset: 3f340ce

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20161005T20:49:11: Michiel Rook commented:

Refs #531 - merge IterableFileSet / FileSet
Changeset: 3f340ce

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20161005T20:49:13: Michiel Rook commented:

Refs #531 - merge IterableFileSet / FileSet
Changeset: 3f340ce

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20161007T08:28:55:

  • mrook commented:

Milestone renamed

  • mrook changed milestone from "3.0" to "4.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants