Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed behavior in <fileset/> filtering in 2.15.1 #593

Closed
holtkamp opened this issue Oct 12, 2016 · 4 comments
Closed

Changed behavior in <fileset/> filtering in 2.15.1 #593

holtkamp opened this issue Oct 12, 2016 · 4 comments
Labels
defect
Milestone
2.15.2

Comments

@holtkamp
Copy link
Contributor

After updating Phing using Composer to 2.15.1, our build.xml script behaves differently:

    <fileset id="secureFiles" dir="${project.dir}/secure">
        <include name="**" />
        <exclude name="**/domain.ext/**" /> <!-- is now INCLUDED in the fileset, probably caused by the .ext? -->
    </fileset>

Might be a regression of https://www.phing.info/trac/ticket/1264?
@holtkamp holtkamp changed the title Changed behavior in 2.15.1 Changed behavior in <fileset/> filtering in 2.15.1 Oct 12, 2016
@mrook mrook added the defect label Oct 12, 2016
@mrook
Copy link
Member

mrook commented Oct 12, 2016

I'll have a look asap, apologies if it turns out to be caused by the fix for https://www.phing.info/trac/ticket/1264.

@mrook mrook modified the milestone: 2.15.2 Oct 12, 2016
mrook added a commit that referenced this issue Oct 12, 2016
@mrook
#593 - include paths in base of fileset
60c43e2
@mrook
Copy link
Member

mrook commented Oct 12, 2016

I think 60c43e2 fixes it, could you please test that?

mrook added a commit that referenced this issue Oct 12, 2016
@mrook
#593 - clean up regex
5de3dcc
@holtkamp
Copy link
Contributor Author

holtkamp commented Oct 12, 2016 •
edited
Loading

Our build script has indeed returned to 'normal' behavior after composer update against dev-master which resulted in:

  - Removing phing/phing (2.15.1)
  - Installing phing/phing (dev-master 5de3dcc)
    Cloning 5de3dcc4effa2753485b3d64a5a64987faea6353 from cache

👍 , so I think this can be closed as soon as a patch version (2.15.2?) is tagged...

@mrook
Copy link
Member

mrook commented Oct 13, 2016

Thanks! I'll release 2.15.2 today.

@mrook mrook closed this as completed Oct 13, 2016
mrook added a commit that referenced this issue Oct 13, 2016
@mrook
#593 - include paths in base of fileset
83aa390
mrook added a commit that referenced this issue Oct 13, 2016
@mrook
#593 - clean up regex
471d858
@dependabot-preview dependabot-preview bot mentioned this issue Mar 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect
Milestone
2.15.2
Development

No branches or pull requests
2 participants
@mrook @holtkamp