Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsHintTask fails when reporter attribute is not set (Trac #1230) #582

Closed
phing-issues-importer opened this issue Oct 9, 2016 · 6 comments

Comments

@phing-issues-importer
Copy link

phing-issues-importer commented Oct 9, 2016

JsHintTask fails when reporter attribute is not set. This config works flawlessly on Phing 2.12.0 and is broken on 2.13.0

<jshint haltOnError="true" haltOnWarning="false">
    <fileset refid="src.js" />
</jshint>

returns (paths are trimmed)

BUILD FAILED
exception 'BuildException' with message 'build.xml:191:18: build.xml:192:61: Unknown severity "warning"' in local/vendor/phing/phing/classes/phing/tasks/ext/ParallelTask.php:89
Stack trace:
https://www.phing.info/trac/ticket/0 local/vendor/phing/phing/classes/phing/UnknownElement.php(100): ParallelTask->main()
https://www.phing.info/trac/ticket/1 local/vendor/phing/phing/classes/phing/Task.php(283): UnknownElement->main()
https://www.phing.info/trac/ticket/2 local/vendor/phing/phing/classes/phing/Target.php(336): Task->perform()
https://www.phing.info/trac/ticket/3 local/vendor/phing/phing/classes/phing/Target.php(366): Target->main()
https://www.phing.info/trac/ticket/4 local/vendor/phing/phing/classes/phing/Project.php(898): Target->performTasks()
https://www.phing.info/trac/ticket/5 local/vendor/phing/phing/classes/phing/Project.php(868): Project->executeTarget('jshint')
https://www.phing.info/trac/ticket/6 local/vendor/phing/phing/classes/phing/Phing.php(679): Project->executeTargets(Array)
https://www.phing.info/trac/ticket/7 local/vendor/phing/phing/classes/phing/Phing.php(191): Phing->runBuild()
https://www.phing.info/trac/ticket/8 local/vendor/phing/phing/classes/phing/Phing.php(316): Phing::start(Array, NULL)
https://www.phing.info/trac/ticket/9 local/vendor/phing/phing/bin/phing.php(58): Phing::fire(Array)
https://www.phing.info/trac/ticket/10 local/vendor/phing/phing/bin/phing(14): require_once('...')
https://www.phing.info/trac/ticket/11 {main}

Migrated from https://www.phing.info/trac/ticket/1230

{
    "status": "new", 
    "changetime": "2016-09-29T08:16:06", 
    "description": "JsHintTask fails when reporter attribute is not set. This config works flawlessly on Phing 2.12.0 and is broken on 2.13.0 \n\n{{{\n<jshint haltOnError=\"true\" haltOnWarning=\"false\">\n    <fileset refid=\"src.js\" />\n</jshint>\n}}}\n\nreturns (paths are trimmed)\n{{{\nBUILD FAILED\nexception 'BuildException' with message 'build.xml:191:18: build.xml:192:61: Unknown severity \"warning\"' in local/vendor/phing/phing/classes/phing/tasks/ext/ParallelTask.php:89\nStack trace:\n#0 local/vendor/phing/phing/classes/phing/UnknownElement.php(100): ParallelTask->main()\n#1 local/vendor/phing/phing/classes/phing/Task.php(283): UnknownElement->main()\n#2 local/vendor/phing/phing/classes/phing/Target.php(336): Task->perform()\n#3 local/vendor/phing/phing/classes/phing/Target.php(366): Target->main()\n#4 local/vendor/phing/phing/classes/phing/Project.php(898): Target->performTasks()\n#5 local/vendor/phing/phing/classes/phing/Project.php(868): Project->executeTarget('jshint')\n#6 local/vendor/phing/phing/classes/phing/Phing.php(679): Project->executeTargets(Array)\n#7 local/vendor/phing/phing/classes/phing/Phing.php(191): Phing->runBuild()\n#8 local/vendor/phing/phing/classes/phing/Phing.php(316): Phing::start(Array, NULL)\n#9 local/vendor/phing/phing/bin/phing.php(58): Phing::fire(Array)\n#10 local/vendor/phing/phing/bin/phing(14): require_once('...')\n#11 {main}\n}}}", 
    "reporter": "anonymous", 
    "cc": "", 
    "resolution": "", 
    "_ts": "1475136966642941", 
    "component": "phing-tasks-ext", 
    "summary": "JsHintTask fails when reporter attribute is not set", 
    "priority": "major", 
    "keywords": "", 
    "version": "2.13.0", 
    "time": "2015-12-08T17:15:03", 
    "milestone": "2.16.0", 
    "owner": "", 
    "type": "defect"
}
@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20151212T10:48:21: mrook commented:

The error message you posted concerns ParallelTask, not JsHintTask?

I can't reproduce your issue, running jsHint without the 'reporter' attribute set:

jshint v2.9.1-rc1
   [jshint] 
   [jshint] JSHint detected 0 errors and 0 warnings.

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20151226T10:06:50:

Project for testing

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20151226T10:15:25: phinginfo.20.dimon3000@spamgourmet.com commented:

Sorry for waiting. I've just attached an example project for reproducing this issue. Parallel task is removed.

BUILD FAILED
exception 'BuildException' with message 'build.xml:9:57: Unknown severity "warning"' in vendor/phing/phing/classes/phing/tasks/ext/JsHintTask.php:204
Stack trace:
#0 vendor/phing/phing/classes/phing/UnknownElement.php(100): JsHintTask->main()
#1 vendor/phing/phing/classes/phing/Task.php(283): UnknownElement->main()
#2 vendor/phing/phing/classes/phing/Target.php(336): Task->perform()
#3 vendor/phing/phing/classes/phing/Target.php(366): Target->main()
#4 vendor/phing/phing/classes/phing/Project.php(898): Target->performTasks()
#5 vendor/phing/phing/classes/phing/Project.php(868): Project->executeTarget('jshint')
#6 vendor/phing/phing/classes/phing/Phing.php(679): Project->executeTargets(Array)
#7 vendor/phing/phing/classes/phing/Phing.php(191): Phing->runBuild()
#8 vendor/phing/phing/classes/phing/Phing.php(316): Phing::start(Array, NULL)
#9 vendor/phing/phing/bin/phing.php(58): Phing::fire(Array)
#10 vendor/phing/phing/bin/phing(14): require_once('-cut-...')
#11 {main}

P.S. Relax your anti-spam filter. I had to go through a quest to submit this comment :)

Submission rejected as potential spam
BotScout says this is spam (Y|MULTI|IP|1|MAIL|1|NAME|0)

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20160929T08:16:06:

  • mrook changed milestone from "Backlog" to "2.16.0"
  • mrook changed priority from "critical" to "major"

@dmromanov
Copy link
Contributor

Is archive phing_1230.tar.gz with an example how to reproduce this bug lost?

@mrook
Copy link
Member

mrook commented Oct 13, 2016

@dmromanov no, it's still available at the original location: https://www.phing.info/trac/ticket/1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants