Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phploc] Json formatter not tested #1483

Closed
jawira opened this issue Dec 21, 2020 · 0 comments · Fixed by #1484
Closed

[phploc] Json formatter not tested #1483

jawira opened this issue Dec 21, 2020 · 0 comments · Fixed by #1484
Assignees
@jawira
Labels
defect ext tasks
Milestone
3.0.0-RC1

Comments

@jawira
Copy link
Contributor

jawira commented Dec 21, 2020

Bug: type="xml" is tested twice, with different output file.

phing/test/etc/tasks/ext/phploc/build.xml

Lines 40 to 43 in 8bb3b37

<formatter type="txt" toDir="${project.basedir}" outFile="phploc-report.txt" />
<formatter type="csv" toDir="${project.basedir}" outFile="phploc-report.csv" />
<formatter type="xml" toDir="${project.basedir}" outFile="phploc-report.xml" />
<formatter type="xml" toDir="${project.basedir}" outFile="phploc-report.json" />

@siad007 siad007 added this to the 3.0.0-rc1 milestone Dec 21, 2020
@siad007 siad007 changed the title Json formatter not tested [phploc] Json formatter not tested Dec 21, 2020
siad007 added a commit that referenced this issue Dec 21, 2020
@siad007
[phploc] Fixed test case.
c8a6c2a 
Closes #1483
@siad007 siad007 mentioned this issue Dec 21, 2020
Merged
siad007 added a commit that referenced this issue Dec 22, 2020
@siad007
[phploc] Fixed test case. (#1484)
dcc6def 
Closes #1483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jawira jawira

Labels
defect ext tasks
Milestone
3.0.0-RC1
Development

Successfully merging a pull request may close this issue.

[phploc] Fixed test case. phingofficial/phing
2 participants
@jawira @siad007