removed some more annotations (#1569)

phingofficial · Apr 1, 2021 · edb315f · edb315f
1 parent c551fb3
commit edb315f
Show file tree

Hide file tree

Showing 32 changed files with 52 additions and 152 deletions.
diff --git a/tests/Phing/Input/ConsoleInputHandlerTest.php b/tests/Phing/Input/ConsoleInputHandlerTest.php
@@ -27,10 +27,6 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Output\NullOutput;
 
-/**
- * @internal
- * @coversNothing
- */
 class ConsoleInputHandlerTest extends TestCase
 {
     public function testDefaultValue()

diff --git a/tests/Phing/Input/NoInteractionInputHandlerTest.php b/tests/Phing/Input/NoInteractionInputHandlerTest.php
@@ -28,10 +28,6 @@
 use Phing\Input\YesNoInputRequest;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class NoInteractionInputHandlerTest extends TestCase
 {
     public function testDefaultValue()

diff --git a/tests/Phing/Io/FileParserFactoryTest.php b/tests/Phing/Io/FileParserFactoryTest.php
@@ -23,13 +23,14 @@
 use Phing\Io\FileParserFactory;
 use Phing\Io\IniFileParser;
 use Phing\Io\YamlFileParser;
+use PHPUnit\Framework\TestCase;
 
 /**
  * Unit test for FileParserFactory.
  *
  * @author Mike Lohmann <mike.lohmann@deck36.de>
  */
-class FileParserFactoryTest extends \PHPUnit\Framework\TestCase
+class FileParserFactoryTest extends TestCase
 {
     /**
      * @var FileParserFactory
@@ -58,7 +59,7 @@ public function tearDown(): void
     }
 
     /**
-     * @covers       \FileParserFactory::createParser
+     * @covers       FileParserFactory::createParser
      * @dataProvider parserTypeProvider
      *
      * @param mixed $parserName

diff --git a/tests/Phing/Io/IniFileParserTest.php b/tests/Phing/Io/IniFileParserTest.php
@@ -20,6 +20,7 @@
 
 namespace Phing\Test\Io;
 
+use org\bovigo\vfs\vfsStream;
 use Phing\Io\File;
 use Phing\Io\IniFileParser;
 use Phing\Io\IOException;
@@ -36,13 +37,13 @@ class IniFileParserTest extends \PHPUnit\Framework\TestCase
     protected function setUp(): void
     {
         $this->parser = new IniFileParser();
-        $this->root = \org\bovigo\vfs\vfsStream::setUp();
+        $this->root = vfsStream::setUp();
     }
 
     /**
      * @dataProvider provideIniFiles
-     * @covers       \IniFileParser::inVal
-     * @covers       \IniFileParser::parseFile
+     * @covers       IniFileParser::inVal
+     * @covers       IniFileParser::parseFile
      *
      * @param mixed $data
      * @param mixed $expected
@@ -57,7 +58,7 @@ public function testParseFile($data, $expected)
     }
 
     /**
-     * @covers \IniFileParser::parseFile
+     * @covers IniFileParser::parseFile
      */
     public function testParseFileCouldntOpenFile()
     {

diff --git a/tests/Phing/Io/YamlFileParserTest.php b/tests/Phing/Io/YamlFileParserTest.php
@@ -55,8 +55,6 @@ public function setUp(): void
     {
         if (!class_exists('\Symfony\Component\Yaml\Parser')) {
             $this->markTestSkipped('Yaml parser is not installed.');
-
-            exit;
         }
         $this->yamlFileStub = PHING_TEST_BASE . '/etc/system/io/config.yml';
         $this->incorrectYamlFileStub = PHING_TEST_BASE . '/etc/system/io/config_wrong.yml';
@@ -72,7 +70,7 @@ public function tearDown(): void
     }
 
     /**
-     * @covers \IniFileParser::parseFile
+     * @covers IniFileParser::parseFile
      */
     public function testParseFileFileNotReadable()
     {
@@ -87,7 +85,7 @@ public function testParseFileFileNotReadable()
     }
 
     /**
-     * @covers \IniFileParser::parseFile
+     * @covers IniFileParser::parseFile
      */
     public function testParseFileFileIncorrectYaml()
     {
@@ -102,7 +100,7 @@ public function testParseFileFileIncorrectYaml()
      * The YamlFileParser has to provide a flattened array which then is
      * compatible to the actual behaviour of properties.
      *
-     * @covers \IniFileParser::parseFile
+     * @covers IniFileParser::parseFile
      */
     public function testParseFileFile()
     {

diff --git a/tests/Phing/Listener/DefaultLoggerTest.php b/tests/Phing/Listener/DefaultLoggerTest.php
@@ -30,10 +30,6 @@
 use PHPUnit\Framework\TestCase;
 use Throwable;
 
-/**
- * @internal
- * @coversNothing
- */
 class DefaultLoggerTest extends TestCase
 {
     /**

diff --git a/tests/Phing/Listener/MonologListenerTest.php b/tests/Phing/Listener/MonologListenerTest.php
@@ -25,10 +25,6 @@
 use Phing\Project;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class MonologListenerTest extends TestCase
 {
     /**

diff --git a/tests/Phing/Listener/SilentLoggerTest.php b/tests/Phing/Listener/SilentLoggerTest.php
@@ -27,10 +27,6 @@
 use Phing\Project;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class SilentLoggerTest extends TestCase
 {
     /**

diff --git a/tests/Phing/Listener/StatisticsListenerTest.php b/tests/Phing/Listener/StatisticsListenerTest.php
@@ -25,10 +25,6 @@
 use Phing\Project;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class StatisticsListenerTest extends TestCase
 {
     /**

diff --git a/tests/Phing/Listener/TimestampedLoggerTest.php b/tests/Phing/Listener/TimestampedLoggerTest.php
@@ -26,10 +26,6 @@
 use Phing\Project;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class TimestampedLoggerTest extends TestCase
 {
     /**

diff --git a/tests/Phing/PropertyHelperTest.php b/tests/Phing/PropertyHelperTest.php
@@ -24,10 +24,6 @@
 use Phing\PropertyHelper;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class PropertyHelperTest extends TestCase
 {
     public function testUndefinedPropertyShouldNotBeReplaced()

diff --git a/tests/Phing/Task/Optional/ArgTest.php b/tests/Phing/Task/Optional/ArgTest.php
@@ -21,12 +21,14 @@
 namespace Phing\Test\Task\Optional;
 
 use Phing\Task\Optional\SymfonyConsoleArg;
+use Phing\Task\OptionalSymfonyConsoleArg;
+use PHPUnit\Framework\TestCase;
 
 /**
  * Test class for Arg.
  * Generated by PHPUnit on 2012-02-13 at 12:02:17.
  */
-class ArgTest extends \PHPUnit\Framework\TestCase
+class ArgTest extends TestCase
 {
     /**
      * @var SymfonyConsoleArg
@@ -51,8 +53,8 @@ protected function tearDown(): void
     }
 
     /**
-     * @covers \SymfonyConsoleArg::getName
-     * @covers \SymfonyConsoleArg::setName
+     * @covers SymfonyConsoleArg::getName
+     * @covers SymfonyConsoleArg::setName
      */
     public function testSetGetName()
     {
@@ -62,8 +64,8 @@ public function testSetGetName()
     }
 
     /**
-     * @covers \SymfonyConsoleArg::getValue
-     * @covers \SymfonyConsoleArg::setValue
+     * @covers SymfonyConsoleArg::getValue
+     * @covers SymfonyConsoleArg::setValue
      */
     public function testSetGetValue()
     {
@@ -73,8 +75,8 @@ public function testSetGetValue()
     }
 
     /**
-     * @covers \SymfonyConsoleArg::getQuotes
-     * @covers \SymfonyConsoleArg::setQuotes
+     * @covers SymfonyConsoleArg::getQuotes
+     * @covers SymfonyConsoleArg::setQuotes
      */
     public function testGetQuotes()
     {
@@ -84,7 +86,7 @@ public function testGetQuotes()
     }
 
     /**
-     * @covers \SymfonyConsoleArg::__toString
+     * @covers SymfonyConsoleArg::__toString
      */
     public function testToStringWithQuotes()
     {
@@ -97,7 +99,7 @@ public function testToStringWithQuotes()
     }
 
     /**
-     * @covers \SymfonyConsoleArg::__toString
+     * @covers SymfonyConsoleArg::__toString
      */
     public function testToStringWithoutQuotes()
     {
@@ -110,7 +112,7 @@ public function testToStringWithoutQuotes()
     }
 
     /**
-     * @covers \SymfonyConsoleArg::__toString
+     * @covers SymfonyConsoleArg::__toString
      */
     public function testToStringJustName()
     {
@@ -122,7 +124,7 @@ public function testToStringJustName()
     }
 
     /**
-     * @covers \SymfonyConsoleArg::__toString
+     * @covers SymfonyConsoleArg::__toString
      */
     public function testToStringJustValueWithoutQuotes()
     {
@@ -134,7 +136,7 @@ public function testToStringJustValueWithoutQuotes()
     }
 
     /**
-     * @covers \SymfonyConsoleArg::__toString
+     * @covers SymfonyConsoleArg::__toString
      */
     public function testToStringJustValueWithQuotes()
     {

diff --git a/tests/Phing/Task/Optional/ComposerTaskTest.php b/tests/Phing/Task/Optional/ComposerTaskTest.php
@@ -23,7 +23,9 @@
 use Phing\Io\FileSystem;
 use Phing\Project;
 use Phing\Task\Optional\ComposerTask;
+use Phing\Task\OptionalComposerTask;
 use Phing\Type\CommandlineArgument;
+use PHPUnit\Framework\TestCase;
 use ReflectionMethod;
 use ReflectionProperty;
 
@@ -32,7 +34,7 @@
  *
  * @author  Nuno Costa <nuno@francodacosta.com>
  */
-class ComposerTaskTest extends \PHPUnit\Framework\TestCase
+class ComposerTaskTest extends TestCase
 {
     /**
      * @var ComposerTask
@@ -58,8 +60,8 @@ protected function tearDown(): void
     }
 
     /**
-     * @covers \ComposerTask::getCommand
-     * @covers \ComposerTask::setCommand
+     * @covers ComposerTask::getCommand
+     * @covers ComposerTask::setCommand
      */
     public function testSetGetCommand()
     {
@@ -69,8 +71,8 @@ public function testSetGetCommand()
     }
 
     /**
-     * @covers \ComposerTask::getPhp
-     * @covers \ComposerTask::setPhp
+     * @covers ComposerTask::getPhp
+     * @covers ComposerTask::setPhp
      */
     public function testSetGetPhp()
     {
@@ -80,7 +82,7 @@ public function testSetGetPhp()
     }
 
     /**
-     * @covers \ComposerTask::setComposer
+     * @covers ComposerTask::setComposer
      */
     public function testSetComposer()
     {
@@ -95,7 +97,7 @@ public function testSetComposer()
     }
 
     /**
-     * @covers \ComposerTask::getComposer
+     * @covers ComposerTask::getComposer
      */
     public function testGetComposerNotOnPath()
     {
@@ -118,7 +120,7 @@ public function testGetComposerNotOnPath()
     }
 
     /**
-     * @covers \ComposerTask::getComposer
+     * @covers ComposerTask::getComposer
      */
     public function testGetComposerFromPath()
     {
@@ -141,7 +143,7 @@ public function testGetComposerFromPath()
     }
 
     /**
-     * @covers \ComposerTask::createArg
+     * @covers ComposerTask::createArg
      */
     public function testCreateArg()
     {

diff --git a/tests/Phing/Task/Optional/IniFileTaskTest.php b/tests/Phing/Task/Optional/IniFileTaskTest.php
@@ -24,10 +24,6 @@
 use Phing\Project;
 use Phing\Test\Support\BuildFileTest;
 
-/**
- * @internal
- * @coversNothing
- */
 class IniFileTaskTest extends BuildFileTest
 {
     /**

diff --git a/tests/Phing/Task/Optional/PHPStan/PHPStanAnalyseCommandBuilderTest.php b/tests/Phing/Task/Optional/PHPStan/PHPStanAnalyseCommandBuilderTest.php
@@ -26,10 +26,6 @@
 use Phing\Task\Ext\Phpstan\PHPStanTask;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class PHPStanAnalyseCommandBuilderTest extends TestCase
 {
     /** @var PHPStanAnalyseCommandBuilder */

diff --git a/tests/Phing/Task/Optional/PHPStan/PHPStanCommandBuilderFactoryTest.php b/tests/Phing/Task/Optional/PHPStan/PHPStanCommandBuilderFactoryTest.php
@@ -30,10 +30,6 @@
 use Phing\Task\Ext\Phpstan\PHPStanTask;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class PHPStanCommandBuilderFactoryTest extends TestCase
 {
     /** @var PHPStanCommandBuilderFactory */

diff --git a/tests/Phing/Task/Optional/PHPStan/PHPStanCommandBuilderTest.php b/tests/Phing/Task/Optional/PHPStan/PHPStanCommandBuilderTest.php
@@ -26,10 +26,6 @@
 use Phing\Task\Ext\Phpstan\PHPStanTask;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @internal
- * @coversNothing
- */
 class PHPStanCommandBuilderTest extends TestCase
 {
     /** @var PHPStanCommandBuilderFake */