Skip to content

Commit

Permalink
[SubPhing] Fail on error should also be passed to the phing task. (#1361
Browse files Browse the repository at this point in the history
)
  • Loading branch information
siad007 authored Jul 4, 2020
1 parent e8f4926 commit 7c88323
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions classes/phing/tasks/system/SubPhing.php
Original file line number Diff line number Diff line change
Expand Up @@ -213,17 +213,17 @@ private function execute(PhingFile $file, ?PhingFile $directory)
}

/**
* Creates the <ant> task configured to run a specific target.
* Creates the <phing> task configured to run a specific target.
*
* @param directory : if not null the directory where the build should run
* @param ?PhingFile $directory : if not null the directory where the build should run
*
* @return PhingTask the ant task, configured with the explicit properties and
* @return PhingTask the phing task, configured with the explicit properties and
* references necessary to run the sub-build.
*/
private function createPhingTask(?PhingFile $directory): PhingTask
{
$phingTask = new PhingTask($this);
$phingTask->setHaltOnFailure(true);
$phingTask->setHaltOnFailure($this->failOnError);
$phingTask->init();
if ($this->subTarget !== null && $this->subTarget !== '') {
$phingTask->setTarget($this->subTarget);
Expand Down

0 comments on commit 7c88323

Please sign in to comment.