Skip to content

Commit

Permalink
Added file.separator and path.separator
Browse files Browse the repository at this point in the history
  • Loading branch information
siad007 authored Jul 7, 2018
1 parent 3d1c41e commit 342b86b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions classes/phing/Phing.php
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,9 @@ private static function setSystemConstants()
} else {
self::setProperty(self::PHP_INTERPRETER, getenv('PHP_COMMAND'));
}
self::setProperty('file.separator', PhingFile::$separator);

This comment has been minimized.

Copy link
@Yousha

Yousha Jul 7, 2018

Why not use DIRECTORY_SEPARATOR ?

self::setProperty('line.separator', PHP_EOL);
self::setProperty('path.separator', PhingFile::$pathSeparator);
self::setProperty(self::PHP_VERSION, PHP_VERSION);
self::setProperty('php.tmpdir', sys_get_temp_dir());
if (strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN') {
Expand Down

0 comments on commit 342b86b

Please sign in to comment.