Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI double builds #143

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Fix CI double builds #143

merged 1 commit into from
Nov 4, 2023

Conversation

philippgille
Copy link
Owner

Double builds were triggered when a maintainer pushed a new commit to an open PR, as it matched the push and the pull_request trigger. This didn't happen when contributors pushed to PRs, as that only triggered the pull_request one.

Double builds were triggered when a maintainer pushed a new commit to an open PR,
as it matched the push and the pull_request trigger.
This didn't happen when contributors pushed to PRs, as that only triggered the pull_request one.
@codecov-commenter
Copy link

Codecov Report

Merging #143 (918b8ff) into master (a09a4d9) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   65.26%   65.26%           
=======================================
  Files          25       25           
  Lines        2096     2096           
=======================================
  Hits         1368     1368           
  Misses        601      601           
  Partials      127      127           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@philippgille philippgille merged commit fd9e993 into master Nov 4, 2023
6 checks passed
@philippgille philippgille deleted the fix-ci-double-builds branch January 7, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants