feat(redis): update to v9 and add context

[glimchb]

following 9c5b7d7
Resolves #132

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

[glimchb]

@philippgille please review

[philippgille]

Thanks for the PR!

So far I was thinking to just update to latest minor+patch versions for the next gokv release, and then bump major versions in the following one. This would keep breaking changes low and people could update from the really old v0.6.0 to a fresh v0.7.0 without worrying too much but getting important security updates.

But OTOH maybe we don't need to follow the same strategy for all packages, for example if there are no breaking changes. Have you checked if in the Redis library v6 to v9 there's anything that could affect gokv users? We're only using a very limited subset of the Redis functionalities, so I could imagine we're not affected, but better to double check.

WDYT?

[glimchb]

Thanks for the PR!

So far I was thinking to just update to latest minor+patch versions for the next gokv release, and then bump major versions in the following one. This would keep breaking changes low and people could update from the really old v0.6.0 to a fresh v0.7.0 without worrying too much but getting important security updates.

But OTOH maybe we don't need to follow the same strategy for all packages, for example if there are no breaking changes. Have you checked if in the Redis library v6 to v9 there's anything that could affect gokv users? We're only using a very limited subset of the Redis functionalities, so I could imagine we're not affected, but better to double check.

WDYT?

Excellent comments!

The main reason to update to v9 was due to otel in #131

Sorry, I haven't checked the Redis library v6 to v9 for breaking changes

CI fails on

Error: ../../../../go/pkg/mod/github.com/redis/go-redis/v9@v9.2.1/commands.go:111:19: undefined: strings.Cut
Error: ../../../../go/pkg/mod/github.com/redis/go-redis/v9@v9.2.1/commands.go:134:18: undefined: strings.Cut
Error: ../../../../go/pkg/mod/github.com/redis/go-redis/v9@v9.2.1/commands.go:154:26: undefined: reflect.Pointer
note: module requires Go 1.18

I understand concern of updating this and deprecating 1.17 is problematic ...

[philippgille]

Sorry, I haven't checked the Redis library v6 to v9 for breaking changes

I just checked https://github.com/redis/go-redis/blob/v8.11.5/CHANGELOG.md (which covers v7 and v8 changes) and https://github.com/redis/go-redis/blob/v9.2.1/CHANGELOG.md (which covers only v9 changes) and I don't think that this PR will lead to breaking changes, thanks to using only basic commands, no pipelining etc.

Regarding the server version used in tests, we already use always the latest here, so that's fine.

[philippgille]

For the error in CI, I'm removing Go 1.17 support now.

Can you update the branch with the latest master changes? If CI is 🟢 (at least for the Redis store) then it's good to go 🚀

[codecov-commenter]

Codecov Report

Merging #130 (63a57e4) into master (bfdf6b8) will increase coverage by 0.26%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   65.00%   65.26%   +0.26%     
==========================================
  Files          25       25              
  Lines        2080     2096      +16     
==========================================
+ Hits         1352     1368      +16     
  Misses        601      601              
  Partials      127      127              

Files	Coverage Δ
redis/redis.go	81.94% <100.00%> (+5.15%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[glimchb]

Can you update the branch with the latest master changes? If CI is 🟢 (at least for the Redis store) then it's good to go 🚀

CI passed @philippgille !

[philippgille]

Thanks again 👍