Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to use latest nightly compiler without manually setting environment variable #381

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Conversation

robert-w-gries
Copy link
Contributor

This PR resolves #379 by manually setting RUST_TARGET_PATH to pwd in the makefile.

Some background can be found in this comment:

Due to rust-lang/cargo#4788 now all users of custom targets will have to set RUST_TARGET_PATH to the directory that contains the specification file if they have any dependency declared in Cargo.toml.

There hasn't been any activity regarding the breakage caused by rust-lang/cargo#4788, so let's change the Makefile so that users don't have to manually set the nightly version anymore.

@phil-opp
Copy link
Owner

phil-opp commented Jan 2, 2018

Thanks a lot!

@phil-opp phil-opp merged commit b188e8a into phil-opp:master Jan 2, 2018
@robert-w-gries robert-w-gries deleted the make_path_fix branch February 18, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Up Rust, Xargo compiling issues
2 participants