Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update rust crate trash to v5 #439

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(deps): update rust crate trash to v5 #439

merged 1 commit into from
Jun 19, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 18, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
trash dependencies major 4 -> 5

Release Notes

ArturKovacs/trash (trash)

v5.0.0

Compare Source

To support non-UTF8 encoding in paths, the name field changed from String
to OsString in the TrashItem struct. As it's a return value, one won't see
code break unless name is actually used.

Bug Fixes
  • Support non-Unicode paths
    There are several spots where paths are assumed to be Unicode. However,
    some (all?) operating systems support non-Unicode paths which causes
    trash-rs to panic if encountered. I switched some of those code to use
    OsStrings instead of Strings. Unfortunately, I had to add a new
    dependency, urlencoding, in order to properly handle decoding non-UTF8
    byte slices.

    As of this commit, the test suite passes and code should be ready, but I
    will try to remove the url crate and use urlencoding in its place
    in the next commit.

Other
  • Use objc2-foundation
Bug Fixes (BREAKING)
  • Support non-UTF8 paths.
    Note that this changes the type of returned paths to OsString from String,
    hence the breaking change.
Commit Statistics
  • 10 commits contributed to the release over the course of 34 calendar days.
  • 47 days passed between releases.
  • 3 commits were understood as conventional.
  • 0 issues like '(#ID)' were seen in commit messages
Commit Details
view details
  • Uncategorized
    • Prepare changelog prior to release (02d1a8d)
    • Support non-UTF8 paths. (0971b8f)
    • Update Windows code to account for API change (e4b7119)
    • Simplify Linux/BSD only tests for non-UTF8 paths (559b57b)
    • Impl test for listing invalid UTF8 trash items (209db9d)
    • Cleanup non-Unicode support for readability (2f31116)
    • Remove url and replace with urlencoding (67fb256)
    • Support non-Unicode paths (15a15f8)
    • Merge pull request #​107 from madsmtm/objc2 (46585ce)
    • Use objc2-foundation (58b99ef)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@abose abose merged commit 685db89 into main Jun 19, 2024
5 checks passed
@abose abose deleted the renovate/trash-5.x branch June 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant