Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1746

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Fixes #1746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
452f3c2
using hide/show
estebanlm Oct 19, 2023
0dc7edf
adding a context to not depend on a singleton
estebanlm Oct 19, 2023
470c169
do not reload spec anymore (it should mostly work now)
estebanlm Oct 19, 2023
a7478c7
Merge branch 'dev-2.0' into fixes
jecisc Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Iceberg-TipUI/IceTipCommitBrowser.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ IceTipCommitBrowser >> initialize [

super initialize.
saveAction := IceTipSaveImageAction new
context: self;
yourself
]

{ #category : 'initialization' }
Expand Down
4 changes: 3 additions & 1 deletion Iceberg-TipUI/IceTipRepositoriesBrowser.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ IceTipRepositoriesBrowser >> addLibGitNotAvailableWarning [

notifyPanel layout add: (notifyPanel newLabel
label: 'There is no libgit2 available in your system! Please verify everything is fine before continue.';
yourself)
yourself).
notifyPanel show
]

{ #category : 'initialization' }
Expand Down Expand Up @@ -170,6 +171,7 @@ IceTipRepositoriesBrowser >> initializePresenters [
notifyPanel := self newPresenter.
notifyPanel layout: SpBoxLayout newVertical.
notifyPanel addStyle: 'libgit2NotAvailable'.
notifyPanel hide.

repositoryNotebook := self newNotebook
]
Expand Down
17 changes: 16 additions & 1 deletion Iceberg-TipUI/IceTipSaveImageAction.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,29 @@ I'm used by the presenter that prepares the commit.
Class {
#name : 'IceTipSaveImageAction',
#superclass : 'Object',
#instVars : [
'context'
],
#category : 'Iceberg-TipUI-Commands',
#package : 'Iceberg-TipUI',
#tag : 'Commands'
}

{ #category : 'accessing' }
IceTipSaveImageAction >> context [

^ context
]

{ #category : 'accessing' }
IceTipSaveImageAction >> context: anObject [

context := anObject
]

{ #category : 'execution' }
IceTipSaveImageAction >> execute [

Smalltalk saveSession.
SpApplication defaultApplication newInform title: 'Image automatically saved'; openModal
self context inform: 'Image automatically saved'
]
Loading