Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

66 remove unneeded new overrides #94

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

lopezca
Copy link
Contributor

@lopezca lopezca commented Jun 26, 2023

Cleans up ^ super new initialize.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #94 (4fe3232) into master (350d8b3) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   77.50%   77.40%   -0.11%     
==========================================
  Files         467      467              
  Lines       49521    49266     -255     
==========================================
- Hits        38382    38135     -247     
+ Misses      11139    11131       -8     
Impacted Files Coverage Δ
...Glorp-Integration-Tests/GlorpTravelFolder.class.st 55.55% <ø> (-4.45%) ⬇️
src/Glorp-Unit-Tests/ASBonus.class.st 64.70% <ø> (-4.53%) ⬇️
src/Glorp-Unit-Tests/ASCustomer.class.st 47.36% <ø> (-3.86%) ⬇️
src/Glorp-Unit-Tests/ASItem.class.st 55.55% <ø> (-4.45%) ⬇️
src/Glorp-Unit-Tests/ASOrder.class.st 57.14% <ø> (-4.15%) ⬇️
src/Glorp-Unit-Tests/GlorpBankAccount.class.st 68.18% <ø> (-2.66%) ⬇️
src/Glorp-Unit-Tests/GlorpBankTransaction.class.st 93.02% <ø> (-0.60%) ⬇️
...c/Glorp-Unit-Tests/GlorpBookstoreCustomer.class.st 57.14% <ø> (-5.36%) ⬇️
...ests/GlorpBreadthFirstTopologicalSortItem.class.st 77.14% <ø> (-2.86%) ⬇️
src/Glorp-Unit-Tests/GlorpCustomer.class.st 93.12% <ø> (-0.21%) ⬇️
... and 57 more

Copy link
Contributor

@astares astares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

@astares astares merged commit 5c06d51 into pharo-rdbms:master Jun 26, 2023
30 checks passed
@lopezca lopezca deleted the 66-remove-unneeded-new-overrides branch June 27, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants