Merge pull request #142 from phalcon/#141-empty-folder-no-throw

#141 - Change `RuntimeException` throw to output warning message
phalcon · May 3, 2023 · 69c1ea9 · 69c1ea9
2 parents 68281b6 + 6058786
commit 69c1ea9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Db/FieldDefinition.php b/src/Db/FieldDefinition.php
@@ -132,7 +132,7 @@ public function isChangedName(FieldDefinition $comparingFieldDefinition): bool
     public function isChangedData(FieldDefinition $comparingFieldDefinition): bool
     {
         $paramsToCheck = get_class_methods(ColumnInterface::class);
-        unset($paramsToCheck['getName']);
+        //unset($paramsToCheck['getName']); // TODO: Validate if this even needed.
 
         $comparingFieldColumn = $comparingFieldDefinition->getColumn();
         foreach ($paramsToCheck as $method) {

diff --git a/src/Migrations.php b/src/Migrations.php
@@ -270,7 +270,8 @@ public static function run(array $options)
                 join(PHP_EOL, $migrationsDirList) :
                 $migrationsDirList;
 
-            throw new RuntimeException('Migrations were not found at:' . PHP_EOL . PHP_EOL . $migrationsPath);
+            echo Color::error('Migrations were not found at:' . $migrationsPath, 'Warning: ');
+            return;
         }
 
         // Set default final version