Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix « empty » checkbox value #16358

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix « empty » checkbox value #16358

merged 1 commit into from
Jun 15, 2023

Conversation

dugwood
Copy link
Contributor

@dugwood dugwood commented Jun 15, 2023

Hello!

(new PR to use the 5.0.x branch)

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Setting checked attribute to an « empty » value doesn't check the checkbox/radio input. « empty » is understand as the return of « empty() » PHP function.

For example 0 and the empty string are considered empty, but <input type="checkbox" name="test" value="0" checked="checked"/> is a valid option that Phalcon 5 doesn't allow.

Thanks

@Jeckerson Jeckerson requested a review from niden June 15, 2023 21:29
@niden niden merged commit 49b7585 into phalcon:5.0.x Jun 15, 2023
@niden
Copy link
Sponsor Member

niden commented Jun 15, 2023

Thank you @dugwood

@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants