Update #11
Merged
Update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 201907_dev
…yet (but it works)
302 and 307 basically do the same thing with just one important difference: The default 302 redirect from express.js tells the browser to repeat the request with the new URL using the GET verb. When using the 307 status code manually, this tells the browser to repeat the very same request against the new URL using all the same parameters, headers and most important HTTP verbs. In practice this is important every time you want to change settings or flip a switch or enter your API key (that information will never arrive at the server) It's even more important when you get to the site through a reverse proxy that doesn't properly set the X-Forwarded-Proto header.
I've changed the explanation for the `INSECURE_USE_HTTP` environment variable. The old first line describing this setting in just one sentence was wrong and the next line basically suggested turning this security feature off in situations where it's not needed. In the nightscout code you check if either the connection is secure by itself or if the X-Forwarded-Proto header is set (which it should be by default in all major reverse proxy applications). It should be unnecessary to change that setting even in a reverse proxy environment.
Perform HTTP to HTTPS redirect using 307 status
Only set INSECURE_USE_HTTP as last resort
Update browser requirements
Merge documentation change back to dev
feat: Allow Node 12 and Node 10.15.2 for Azure
…n the color view * HIDE_CLOCK_CLOSEBUTTON setting to hide the button altogether (set to TRUE or ON to hide buttons altogether) * Fix CSS for toolbar positioning in the main view * Fix documentation on the clock URLs and add mention of the setting
… event that are both outside the 2-day full data load window
Load the latest 'Sensor Stop' event from last 32 days
* add support for different color prediction lines * changed quotation marks to better fit guidelines * corrected and standardized variable names * added support for colored ACOB prediction and changed default prediction line colors * added default colour for 'Values' prediction
…amsung phones, Kindle Fire)
Update clock view notes
… changed in the client. Needs expanding on later - currently only supports booleans as checkboxes.
feat: Less obtrusive clock close button
feat: browser setting for openaps color lines
D3 cleanup
Fix for distributionpage
fix focus scale hour format
Set Auth Dialog Width to Client Width Client Smaller Than Default Width
API versions list
Update virtual assistants v2
API3 read-only documents
More hebrew translations
Russian translation update edit
* Added sanity check for the bridge interval value, setting minimum allowed value to 30 seconds and maximum to 5 minutes. This is to avoid input of very low values which might overload the dexcom servers. * Added missin ';' * Fixed typoe in comment * Added test for default interval (not set in config) * Set lower limit to 1 second
* Allow auth tokens to be passed in the api-secret header and used in the client in place of the API secret * Fix unit test * Fix admin test * Reload page when token is used as a secret
…n numbering should really work
To use cgm-remote-monitor as npm package, the main attribute is required.
* Revert "change default back to 3HR" This reverts commit e60ff3a. * shorten HR to H to avoid line-wrapping on mobile * try larger label font: 35 instead of 25 (vs. 40) * add comma * deviceInfo.recent null check * default back to 3, w/ 4 as an option * re-add H to single-digit hours * * Don't use cache manifest all all for development * Add 4 hours option to view and change the labelling to remove language issues * Have page scale the minor pill widths more gracefully
* Fix !delta check for delta == 0 * Fixed delta comparison
* Read BG targets in using mmol when server is in mmol mode * Change the Heroku template to match the new logic * Deal with mmol targets being set using commas
…ular data reference
Nightscout Release 13.0.0
* Release ref update v2 (#5301) * Updated release name and number * Added missing version number * Added missing version number * Fix auth dialog sizing error (#5315) * Fix auth dialog sizing error (#5314) * Fix auth dialog sizing error * Fix Client Init After Auth (cherry picked from commit 1bf416c) * update NS minor version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.