Skip to content

Commit

Permalink
fix(test): flaky fabric AIO container boot hyperledger#876
Browse files Browse the repository at this point in the history
Epic facepalm once again. Turns out the default restart try
count of supervisord is too low which leads to race conditions.
Increasing the retry count from 4 to 20 should do it, this way
the fabric-network process (see supervisord.conf file) should
be 5 times as "patient" waiting for the docker daemon to launch
within the AIO container.

What was happening before is that the fabric-network script
tried launching itself in parallel with the docker daemon, but
it would time out before the docker daemon could come online.

Fixes hyperledger#876

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Sep 2, 2021
1 parent 2161e0d commit 4a1ef7c
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/docker/fabric-all-in-one/supervisord.conf
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ loglevel = debug
command=/usr/sbin/sshd -D
autostart=true
autorestart=true
startretries=20
stderr_logfile=/dev/stderr
stderr_logfile_maxbytes=0
stdout_logfile=/dev/stdout
Expand All @@ -17,6 +18,7 @@ stdout_logfile_maxbytes=0
command=dockerd-entrypoint.sh
autostart=true
autorestart=true
startretries=20
stderr_logfile=/dev/stderr
stderr_logfile_maxbytes=0
stdout_logfile=/dev/stdout
Expand All @@ -26,6 +28,7 @@ stdout_logfile_maxbytes=0
command=/run-fabric-network.sh
autostart=true
autorestart=unexpected
startretries=20
stderr_logfile=/dev/stderr
stderr_logfile_maxbytes=0
stdout_logfile=/dev/stdout
Expand Down

0 comments on commit 4a1ef7c

Please sign in to comment.