Add missing test file #2525
Merged
Add missing test file #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you have closer look on why the tests in the pipeline did not fail when the file was missing? |
|
Had a look now. The Coverage P-tests are skipped in v6 pipeline due to use of |
|
Yeah I need to fix that, or run those tests separately. I think I disabled them because they were turning off tracing and breaking the overall code coverage. |
nohwnd
added a commit
that referenced
this pull request
Jul 10, 2024
* Implement CodeCoverage.ExcludeTests * Update src/functions/Coverage.ps1 * Add missing test file Fixed in #2525 for main (v6) * Fix tests --------- Co-authored-by: Frode Flaten <3436158+fflaten@users.noreply.github.com> Co-authored-by: Jakub Jareš <me@jakubjares.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I'm not sure how #2523 passed checks, but this file was not committed. Discovered in backport PR #2524 where tests failed.
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.