HaveParameter is not dependent on format of param block #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fflaten
requested changes
Feb 1, 2023
There was a problem hiding this comment.
Thanks for looking into this issue!
This looks great - and so much simpler! I've added a few suggestions.
Would you mind also adding a test in tst/functions/assertions/HaveParameter.Tests.ps1?
Ex the one you provided in the issue comment?
|
Commenter does not have sufficient privileges for PR 2288 in repo pester/Pester |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fflaten
requested changes
Feb 19, 2023
…ded dedicated test for paramblock with opening paren on new line
nohwnd
approved these changes
Mar 31, 2023
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Get-ParameterInfo wasn't leveraging ASTs because of previous support for PowerShell v2 and required that the opening parenthesis for the param block be on the same line as the keyword. This change leverages ASTs for Get-ParameterInfo so that HaveParmeter is format agnostic.
Fix #2285
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.