Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]Everest 1004 max width for content container #287

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

X6uddy
Copy link
Contributor

@X6uddy X6uddy commented May 12, 2024

https://perconadev.atlassian.net/browse/EVEREST-1004

set the maximum width for the content container to 1280px.

before:
image
image

after:
image
image

@X6uddy X6uddy requested a review from a team as a code owner May 12, 2024 08:54
@solovevayaroslavna solovevayaroslavna marked this pull request as draft May 16, 2024 15:32
@solovevayaroslavna
Copy link
Contributor

solovevayaroslavna commented May 16, 2024

needs design review
image

@Daninda
Copy link
Contributor

Daninda commented Jun 24, 2024

Updated:

2024-06-25.09-41-37.mp4

@solovevayaroslavna solovevayaroslavna marked this pull request as ready for review June 25, 2024 05:53
Copy link
Collaborator

@fabio-silva fabio-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution @Daninda .
From this video you posted, I can tell that the page shrinks when a column is removed from the table, which I think should not happen

@solovevayaroslavna
Copy link
Contributor

solovevayaroslavna commented Jun 27, 2024

@fabio-silva
Nuna asked in the ticket to set max width to 1280px, but some tables is bigger then 1280px, so it turned out that a large table was wrapped in a scroll and looks like we cannot limit the width of the table to any width if the screen is larger than the table.
And I see 2 ways
1 - we show by the width of the content, which will inevitably lead to jumps when changing the number of column
2 - we somehow adjust the width of the table to fit the screen, but in this case, the content may spread out on large screens, which Nuna would like to avoid
maybe you have another thought how we can handle it without spreading out on the big screen, without limiting the width to a specific number?
3. I can assume to set the width on each page to different sizes, but... I'm trying to find a "flex" way to deal with this

@solovevayaroslavna solovevayaroslavna marked this pull request as draft July 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants