Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added inflection to Pipfile dependency list #305

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jonrxu
Copy link
Contributor

@jonrxu jonrxu commented Sep 1, 2024

Fix this issue:

Screenshot 2024-09-01 at 1 48 22 PM

Broken link at https://pennmobile.org/api/documentation/ due to dependency issue

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (1e21aa9) to head (cb37d1b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   90.55%   90.52%   -0.04%     
==========================================
  Files          62       62              
  Lines        2658     2659       +1     
==========================================
  Hits         2407     2407              
- Misses        251      252       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vcai122 vcai122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Also, next time, tag me as a reviewer on github so I get the email notif

@jonrxu jonrxu merged commit 0bce824 into master Sep 6, 2024
8 of 9 checks passed
@jonrxu jonrxu deleted the jonx/fix-pipfile-dependency branch September 6, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants