Update __init__.py #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate generator.
|
Good catch, thanks for fixing this! It is probably a left over since before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the generator.
Self is already iterable so an additional generator is overhead. I think this may have been useful at some point because other data types may have been allowed? (Which would need to be converted to string before join.)
However,
_iter_node_context()currently prevents this. Unexpected data types result in a ValueError (which probably should be a TypeError, now that I think of it), everything else is ultimately converted to string.I get around a 2% speedup from your benchmark script with the generator removed. Not a huge difference but better than a poke in the eye.