Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup java images #175

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Cleanup java images #175

merged 2 commits into from
Aug 14, 2023

Conversation

gOOvER
Copy link

@gOOvER gOOvER commented Aug 14, 2023

Description

  • image cleanup
  • update images to jammy

All Submissions:

  • Have you ensured there aren't other open Pull Requests for the same update or change?
  • Have you created a new branch for your changes and PR from that branch and not from your master branch?

@QuintenQVD0
Copy link
Collaborator

QuintenQVD0 commented Aug 14, 2023

@gOOvER Edit: the cleanup is fine and the move to jammy.

I now see the issue that they introduced. does it work when you set it to bash and not sh and even more to the full path so /bin/bash instead of just sh or bash.

edit 2:
Tomcat just set the entrypoint to docker-library/tomcat@55546d6

@QuintenQVD0
Copy link
Collaborator

I see, this is comming because they have an entrypoint now in there images, see:

adoptium/containers#392
adoptium/containers@05b7f08#diff-f039b99538d3a63ca08a6fd9e5a9ff5f5a6108066c058902dacbea9b928e635f

@gOOvER
Copy link
Author

gOOvER commented Aug 14, 2023

@gOOvER Edit: the cleanup is fine and the move to jammy.

I now see the issue that they introduced. does it work when you set it to bash and not sh and even more to the full path so /bin/bash instead of just sh or bash.

edit 2:
Tomcat just set the entrypoint to docker-library/tomcat@55546d6

dont Test IT, but this works fine for me.

what excact you mean with full path?

@parkervcp
Copy link
Collaborator

I'll pr a fix for the script perms instead of updating all this. That would fix this.

@parkervcp
Copy link
Collaborator

My PR #176 resolves this without editing all the Dockerfiles.

@parkervcp parkervcp closed this Aug 14, 2023
@QuintenQVD0 QuintenQVD0 reopened this Aug 14, 2023
Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuintenQVD0 QuintenQVD0 changed the title fixes permission denided error Cleanup java images Aug 14, 2023
@QuintenQVD0 QuintenQVD0 merged commit a62025a into pelican-eggs:master Aug 14, 2023
@gOOvER gOOvER deleted the javafix branch September 26, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants