Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce unnecessary timeouts #436

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: reduce unnecessary timeouts #436

merged 1 commit into from
Dec 5, 2023

Conversation

jonasgloning
Copy link
Member

@jonasgloning jonasgloning commented Dec 5, 2023 •
edited
Loading

Intensive throttling might result in heartbeats being sent only once a minute. For more information, see https://developer.chrome.com/blog/timer-throttling-in-chrome-88

I increased the timout of the public instance to 90s. Some early results:

SELECT 
    (filter(count(*), WHERE duration >= 85 AND duration <= 95) * 100) / filter(count(*), WHERE transactionType = 'Other') 
    AS 'Percentage of Requests in 85-95s Range'
FROM 
    Transaction 
WHERE 
    entityGuid = '....' 
    AND transactionType = 'Other' 
SINCE 
    1 day ago
Interval 60s Timout 90s Timout
55s-65s 14.3% 4.55%
85s-95s 1.55% 7.53%

Approximately 12.75% (14.3% - 1.55%) of connections were terminated due to the timeout, while only 2.98% (7.53% - 4.55%) were actually dead.

@jonasgloning
fix: reduce unnecessary timeouts
2e105ca 
Intensive throttling might result in heartbeats being sent only once a minute. This change adjusts the timeout to 90 seconds. For more information, see https://developer.chrome.com/blog/timer-throttling-in-chrome-88
Thank you, @e-nikolov.

Closes #431.
@jonasgloning jonasgloning self-assigned this Dec 5, 2023
@jonasgloning jonasgloning enabled auto-merge (rebase) December 5, 2023 19:59
@jonasgloning jonasgloning merged commit 638af56 into master Dec 5, 2023
12 of 13 checks passed
@jonasgloning jonasgloning deleted the increase-timeout branch December 5, 2023 19:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 1.1.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonasgloning jonasgloning

Labels
released on @rc released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonasgloning