Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a PR to Support Redis for message passing between client #195

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

chattes
Copy link

@chattes chattes commented May 31, 2020

Ability to use Redis Pub Sub to pass messaged between webrtc clients connected across mutiple servers.

@KaiserKarel
Copy link

I myself am in need of this feature as well. Perhaps it is however better to abstract the redis portion, to allow for different backends such as memcache.

Also there's quite a few console logs left.

@chattes
Copy link
Author

chattes commented Jun 12, 2020

yeah i will remove the console.log. Let me check how we can abstract the Radis part away. Thanks

Copy link
Member

@afrokick afrokick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why files permissions was changed?

}
cert: "",
},
redis: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rather suggest to use an object to describe redis config:

redis: {
  host: "",
  port: 0,
}

@@ -8,6 +8,8 @@ import { Client, IClient } from "../../models/client";
import { IRealm } from "../../models/realm";
import { MyWebSocket } from "./webSocket";

const Redis = require("ioredis");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use import instead

@afrokick
Copy link
Member

Like @KaiserKarel said, we should use an abstraction to transfer/handle messages. I have an idea how to do it.

I suggest to move this PR to separate package to extends peerjs server with Redis. Others stuff like RabbitMQ, Memcache etc also should be separated packages.

@JackMF
Copy link

JackMF commented Mar 14, 2021

Hey just wondering if there are any updates on this PR? would be intersted to try it out

@spayse
Copy link

spayse commented Jul 17, 2021

THIS PROJECT SEEMS COOL THX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants