Do not upload an empty tarball

[paymand]

Change

Make sure we do not upload an empty tarball to S3.

Example build when node_modules folder doesn't exist: https://buildkite.com/peakon/backoffice-browser-tests/builds/532#018875e0-be0d-4b57-b05b-fd5707ca50d0/329-334

Uploading new cache for key: v2-node-modules-c81a986317355c12556a1aad2700cfb046285f61
tar: node_modules: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors
Failed to upload new cache for key: v2-node-modules-c81a986317355c12556a1aad2700cfb046285f61

Problem / Why

There's bug in the plugin where when tar -cz ... fails, for instance when we have a non-existing path, since we are using --ignore-failed-read we end up creating and uploading an empty tarball.

Example build when node_modules folder doesn't exist:
https://buildkite.com/peakon/backoffice/builds/3230#018875d5-f91c-4714-b961-a1deec8f2fb0/383-388

Uploading new cache for key: v2-node-modules-c81a986317355c12556a1aad2700cfb046285f61
tar: node_modules: Warning: Cannot stat: No such file or directory
Uploaded new cache for key: v2-node-modules-c81a986317355c12556a1aad2700cfb046285f61

Here we uploaded an empty tarball 🐛

References

• https://workday-dev.slack.com/archives/C01TN7LUFNE/p1685131491039969

[paymand]

mmm, unit tests pass for me locally: 😢