Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Add placeholders #152

Closed
Andre601 opened this issue Jun 21, 2020 · 5 comments
Closed

proposal: Add placeholders #152

Andre601 opened this issue Jun 21, 2020 · 5 comments
Assignees
Labels

Comments

@Andre601
Copy link
Contributor

Is your feature request related to a problem? Please describe.
From what I can tell (And what I tested so far) can you not just use something like ${{ github.event.sender.login }} to display the name of the person opening the issue/Pull request.

Describe the solution you'd like
It would be nice to have some placeholders which could be used for things like the name of the person opening the issue/Pull request.

This would allow messages like Thank you @{user} for reporting this bug! which would be translated to Thank you @Andre601 for reporting this bug! and mention the user in the process.

Describe alternatives you've considered
There doesn't seem to be any alternatives available

Additional context

@peaceiris
Copy link
Owner

I have released v1.4.0-0 and tested at #158.

- name: proposal
labeled:
issue:
body: |
Thank you @{{ sender.login }} for suggesting this.
The maintainer will reply.

Could you test v1.4.0-0? And, do you have any ideas about another useful variable?

@Andre601

This comment has been minimized.

@Andre601
Copy link
Contributor Author

It does work.

And I at most can think of perhaps a placeholder to list asigned people for the PR/issue.
Maybe something like {{ assignees }} for a comma separated list of assigned people and {{ assignees.n.login }} for a specific one (n would be a 0 indexed number) and if nothing is there, the placeholder wouldn't be changed.
And maybe in case someone wants this {{ assignees.mention }} which would return the names of each assignee as a mention.

@Andre601
Copy link
Contributor Author

I find an issue using {{ sender.login }}

It seems to use whoever last replied to, or performed actions on an issue/PR even if the creator of it is a different one.
For example if ExampleUser creates an issue and I assign a label that responds with Hello @{{ sender.login }} will the result be Hello @Andre601

@peaceiris
Copy link
Owner

@{{ issue.user.login }} is available now.

issue: #261
pr: #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants