-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shebang line to script in tools #408
Conversation
Should it not be python3 as the python 2 no longer supported in line with https://www.python.org/dev/peps/pep-0394/ ? |
As python2 is now "deprecated" since January 2020, I didn't think about it. I must admit that according to https://www.python.org/dev/peps/pep-0394/#future-changes-to-this-recommendation, authors says the PEP394 should be update if the support for python2 is completly drop. On the other hand, most of scripts already containing the shebang line used the "python" and not "python3", so I really don't know. |
@fabbox the Python PEP requirement is that for programs, such as this, which are incompatible with python2 and only work on python3, the shebang should specifically reference python3. It is wrong to use |
Why did you close this PR, abandon the review, and open a new PR #421 with the exact same content? |
I close this pull request and creat a new one with the proposition (with python3). |
Sure, this PR even updated when you pushed additional commits, then a minute later you closed it. Github doesn't require you to close a PR and open a new one, ever. |
OK, I think I miss something in the PR workflow. I didn't find how to edit the PR. I will close the new one and try to update this one. Sorry to all, my bad here, I was thinking it do not accept my PR but it was updating it... |
@fabbox Thanks! |
@pietermarsman I'm a maintainer of a pdfminer.six-feedstock repositry which enables installation of pdfminer.six via conda. |
@estshorter done! Let me know if it works. |
Thanks @pietermarsman ! |
This update fix #405.
It enables to run the scripts in tools (especially pdf2txt.py and dumppdf.py) directly from terminal.